>>>>> "Peter" == Peter Geoghegan <p...@heroku.com> writes:
>> So if these debugging elogs are to be kept at all, I propose that >> rather than being compile-time options they should be controlled by >> a debug_sortsupport GUC. Opinions? Peter> This seems like a reasonable idea. Why wouldn't it just be under Peter> the existing trace_sort GUC, though? That's been enabled by Peter> default since 8.1. It's already defined in pg_config_manual.h. Ungh... yes, it's defined by default, but it clearly still requires keeping the #ifdefs in there in order to still build if someone manually undefines it. Was hoping to avoid the #ifdefs entirely - perhaps the existing #ifdefs should just be removed? If it's been enabled since 8.1 it seems unlikely to be causing anyone any issues. -- Andrew (irc:RhodiumToad) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers