>>>>> "Andres" == Andres Freund <and...@anarazel.de> writes:

 >> This replaces the one I posted before; it does both INT64_MIN/MAX and
 >> INT32_MIN/MAX, and also int16/int8/uint*. Uses of 0x7fffffff in code
 >> have been replaced unless there was a reason not to, with either INT_MAX
 >> or INT32_MAX according to the type required.

 Andres> Any reason you did that for most of 0x7FFFFFFF, but not for the
 Andres> corresponding 0xFFFFFFFF/unsigned case? I'd like to either
 Andres> avoid going around changing other definitions, or do a somewhat
 Andres> systematic job.

I didn't replace the 0xFFFFFFFF ones because most or all of them looked
like basically bit-masking operations rather than actually dealing with
the bounds of an unsigned int or uint32.  I was specifically looking for
places where literals were being used to represent maximum or minimum
values.

-- 
Andrew (irc:RhodiumToad)


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to