On Sun, Apr 26, 2015 at 2:19 AM, Andrew Dunstan <and...@dunslane.net> wrote: > > On 04/25/2015 10:53 AM, Michael Paquier wrote: >> >> On Sat, Apr 25, 2015 at 9:58 PM, Peter Eisentraut wrote: >>> >>> On 4/24/15 12:22 AM, Michael Paquier wrote: >>>> >>>> Now that the stuff related to the move from contrib/ to src/bin/, >>>> modulescheck and tmp_install has been committed, shouldn't we give a >>>> new shot at this patch? Attached is a rebased version. >>> >>> done >> >> Thanks, bowerbird is running fine: >> >> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2015-04-25%2013%3A31%3A06 > > > > But currawong is not - it runs an older version of the MS build tools. See > <http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=currawong&dt=2015-04-25%2016%3A31%3A12>: > > Bad format filename 'src/backend/access/brin/brin.c' > at src/tools/msvc/VCBuildProject.pm line 73. > VCBuildProject::WriteFiles(VC2008Project=HASH(0x9a7274), > "*Project::F") called at src/tools/msvc/Project.pm line 363 > Project::Save(VC2008Project=HASH(0x9a7274)) called at > src/tools/msvc/Solution.pm line 539 > Solution::Save(VS2008Solution=HASH(0xc00b7c)) called at > src/tools/msvc/Mkvcbuild.pm line 656 > Mkvcbuild::mkvcbuild(HASH(0xbed464)) called at build.pl line 36
Oops, attached is a patch that should make currawong happier.. -- Michael
diff --git a/src/tools/msvc/VCBuildProject.pm b/src/tools/msvc/VCBuildProject.pm index 513cfb5..dda662f 100644 --- a/src/tools/msvc/VCBuildProject.pm +++ b/src/tools/msvc/VCBuildProject.pm @@ -71,7 +71,7 @@ EOF foreach my $fileNameWithPath (sort keys %{ $self->{files} }) { confess "Bad format filename '$fileNameWithPath'\n" - unless ($fileNameWithPath =~ /^(.*)\\([^\\]+)\.(c|cpp|y|l|rc)$/); + unless ($fileNameWithPath =~ m!^(.*)/([^/]+)\.(c|cpp|y|l|rc)$!); my $dir = $1; my $file = $2;
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers