Fabrízio de Royes Mello wrote: > I have this idea: > > 1) Add an ObjectAddress field to CommentStmt struct an set it in gram.y > > 2) In the CommentObject check if CommentStmt->address is > InvalidObjectAddress then call get_object_address else use it
For DDL deparsing purposes, it seems important that the affected object address can be reproduced somehow. I think pg_get_object_address() should be considered, as well as the object_address test. If we do as you propose, we would have to deparse COMMENT ON CURRENT DATABASE IS 'foo' as COMMENT ON DATABASE whatever_the_name_is IS 'foo' which is not a fatal objection but doesn't seem all that great. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
