On Fri, May 8, 2015 at 9:34 PM, Heikki Linnakangas <hlinn...@iki.fi> wrote: > On 05/08/2015 03:25 PM, Vladimir Borodin wrote: >> Seems, that pg_rewind does not account --dry-run option properly. A simple >> fix >> for that is attached. > > > No, the --dry-run takes effect later. It performs all the actions it > normally would, including reading files from the source, except for actually > writing anything in the target. See the dry-run checks in file_ops.c
Even if the patch sent is incorrect, shouldn't there be some process bypass in updateControlFile() and createBackupLabel() in case of a --dry-run? -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
