* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Stephen Frost wrote: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > > I think the code is OK, but yeah, this comment should be changed to > > > reflect the idea that the function will append entries to an existing > > > list of name/value pairs (and thus, that head_p/tail_p are not output > > > but in/out parameters). > > > > I've pushed a fix for the comment to address this. > > This open-coded list thingy is pretty odd. I wonder if it'd be nicer to > replace it with ilist. (Not for 9.5, of course.)
I have a feeling that much of the GUC machinery could be reworked; as
Jim mentioned up-thread, it might be possible to use memory contexts too
which would make a lot of it much cleaner, I believe.
Agreed that it's not for 9.5 though.
Thanks!
Stephen
signature.asc
Description: Digital signature
