Hi all, Since dcae5fac, we use a central path ($GIT_ROOT/tmp_install) to store the installation deliverables during tests. Each module uses a .gitignore with more or less those entries: /log/ /results/ /tmp_check/
First note that /log/ is not used anymore, replaced by /tmp_check/log/ so we could just remove it. Also, as we do not ignore regression.diffs and regression.out on purpose to check easily what has failed, what about removing /tmp_check/ as well in those .gitignore files? It now contains pgdata/ and log/, so it looks useful to me to show it with git status to track it in case of failure as well. Thoughts? Attached is a patch with all those files updated. -- Michael
diff --git a/contrib/btree_gin/.gitignore b/contrib/btree_gin/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/btree_gin/.gitignore +++ b/contrib/btree_gin/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/btree_gist/.gitignore b/contrib/btree_gist/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/btree_gist/.gitignore +++ b/contrib/btree_gist/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/citext/.gitignore b/contrib/citext/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/citext/.gitignore +++ b/contrib/citext/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/cube/.gitignore b/contrib/cube/.gitignore index cb4c989..a6484a0 100644 --- a/contrib/cube/.gitignore +++ b/contrib/cube/.gitignore @@ -1,6 +1,4 @@ /cubeparse.c /cubescan.c # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/dblink/.gitignore b/contrib/dblink/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/dblink/.gitignore +++ b/contrib/dblink/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/dict_int/.gitignore b/contrib/dict_int/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/dict_int/.gitignore +++ b/contrib/dict_int/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/dict_xsyn/.gitignore b/contrib/dict_xsyn/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/dict_xsyn/.gitignore +++ b/contrib/dict_xsyn/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/earthdistance/.gitignore b/contrib/earthdistance/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/earthdistance/.gitignore +++ b/contrib/earthdistance/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/file_fdw/.gitignore b/contrib/file_fdw/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/file_fdw/.gitignore +++ b/contrib/file_fdw/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/hstore/.gitignore b/contrib/hstore/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/hstore/.gitignore +++ b/contrib/hstore/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/hstore_plperl/.gitignore b/contrib/hstore_plperl/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/hstore_plperl/.gitignore +++ b/contrib/hstore_plperl/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/hstore_plpython/.gitignore b/contrib/hstore_plpython/.gitignore index ce6fab9..351dd41 100644 --- a/contrib/hstore_plpython/.gitignore +++ b/contrib/hstore_plpython/.gitignore @@ -1,6 +1,4 @@ # Generated subdirectories /expected/python3/ -/log/ /results/ /sql/python3/ -/tmp_check/ diff --git a/contrib/intarray/.gitignore b/contrib/intarray/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/intarray/.gitignore +++ b/contrib/intarray/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/ltree/.gitignore b/contrib/ltree/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/ltree/.gitignore +++ b/contrib/ltree/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/ltree_plpython/.gitignore b/contrib/ltree_plpython/.gitignore index ce6fab9..351dd41 100644 --- a/contrib/ltree_plpython/.gitignore +++ b/contrib/ltree_plpython/.gitignore @@ -1,6 +1,4 @@ # Generated subdirectories /expected/python3/ -/log/ /results/ /sql/python3/ -/tmp_check/ diff --git a/contrib/pg_trgm/.gitignore b/contrib/pg_trgm/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/pg_trgm/.gitignore +++ b/contrib/pg_trgm/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/pgcrypto/.gitignore b/contrib/pgcrypto/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/pgcrypto/.gitignore +++ b/contrib/pgcrypto/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/pgstattuple/.gitignore b/contrib/pgstattuple/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/pgstattuple/.gitignore +++ b/contrib/pgstattuple/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/postgres_fdw/.gitignore b/contrib/postgres_fdw/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/postgres_fdw/.gitignore +++ b/contrib/postgres_fdw/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/seg/.gitignore b/contrib/seg/.gitignore index 69e73d2..102f8b3 100644 --- a/contrib/seg/.gitignore +++ b/contrib/seg/.gitignore @@ -1,6 +1,4 @@ /segparse.c /segscan.c # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/tablefunc/.gitignore b/contrib/tablefunc/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/tablefunc/.gitignore +++ b/contrib/tablefunc/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/test_decoding/.gitignore b/contrib/test_decoding/.gitignore index 1f95503..a794c4f 100644 --- a/contrib/test_decoding/.gitignore +++ b/contrib/test_decoding/.gitignore @@ -1,5 +1,3 @@ # Generated subdirectories -/log/ /isolation_output/ /regression_output/ -/tmp_check/ diff --git a/contrib/tsearch2/.gitignore b/contrib/tsearch2/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/tsearch2/.gitignore +++ b/contrib/tsearch2/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/unaccent/.gitignore b/contrib/unaccent/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/unaccent/.gitignore +++ b/contrib/unaccent/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/uuid-ossp/.gitignore b/contrib/uuid-ossp/.gitignore index 6c989c7..0eaa48a 100644 --- a/contrib/uuid-ossp/.gitignore +++ b/contrib/uuid-ossp/.gitignore @@ -1,6 +1,4 @@ /md5.c /sha1.c # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/contrib/xml2/.gitignore b/contrib/xml2/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/contrib/xml2/.gitignore +++ b/contrib/xml2/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/src/bin/initdb/.gitignore b/src/bin/initdb/.gitignore index 71a899f..0f74727 100644 --- a/src/bin/initdb/.gitignore +++ b/src/bin/initdb/.gitignore @@ -2,5 +2,3 @@ /localtime.c /initdb - -/tmp_check/ diff --git a/src/bin/pg_basebackup/.gitignore b/src/bin/pg_basebackup/.gitignore index 36a2f12..7abea15 100644 --- a/src/bin/pg_basebackup/.gitignore +++ b/src/bin/pg_basebackup/.gitignore @@ -1,5 +1,3 @@ /pg_basebackup /pg_receivexlog /pg_recvlogical - -/tmp_check/ diff --git a/src/bin/pg_config/.gitignore b/src/bin/pg_config/.gitignore index cc42247..169bc76 100644 --- a/src/bin/pg_config/.gitignore +++ b/src/bin/pg_config/.gitignore @@ -1,2 +1 @@ /pg_config -/tmp_check/ diff --git a/src/bin/pg_controldata/.gitignore b/src/bin/pg_controldata/.gitignore index 051d71d..eab0c28 100644 --- a/src/bin/pg_controldata/.gitignore +++ b/src/bin/pg_controldata/.gitignore @@ -1,2 +1 @@ /pg_controldata -/tmp_check/ diff --git a/src/bin/pg_ctl/.gitignore b/src/bin/pg_ctl/.gitignore index 73ab4ed..c90c103 100644 --- a/src/bin/pg_ctl/.gitignore +++ b/src/bin/pg_ctl/.gitignore @@ -1,2 +1 @@ /pg_ctl -/tmp_check/ diff --git a/src/bin/pg_rewind/.gitignore b/src/bin/pg_rewind/.gitignore index 9ade7ef..1c5e162 100644 --- a/src/bin/pg_rewind/.gitignore +++ b/src/bin/pg_rewind/.gitignore @@ -3,5 +3,4 @@ /pg_rewind # Generated by test suite -/tmp_check/ /regress_log/ diff --git a/src/bin/pg_upgrade/.gitignore b/src/bin/pg_upgrade/.gitignore index d24ec60..5e3ee03 100644 --- a/src/bin/pg_upgrade/.gitignore +++ b/src/bin/pg_upgrade/.gitignore @@ -4,5 +4,3 @@ /delete_old_cluster.sh /analyze_new_cluster.bat /delete_old_cluster.bat -/log/ -/tmp_check/ diff --git a/src/bin/scripts/.gitignore b/src/bin/scripts/.gitignore index 1056b28..0b9b786 100644 --- a/src/bin/scripts/.gitignore +++ b/src/bin/scripts/.gitignore @@ -14,5 +14,3 @@ /kwlookup.c /mbprint.c /print.c - -/tmp_check/ diff --git a/src/interfaces/ecpg/test/.gitignore b/src/interfaces/ecpg/test/.gitignore index d60b197..9b2da1b 100644 --- a/src/interfaces/ecpg/test/.gitignore +++ b/src/interfaces/ecpg/test/.gitignore @@ -1,5 +1,3 @@ /pg_regress # Exclude subdirectories -/log/ /results/ -/tmp_check/ diff --git a/src/pl/plperl/.gitignore b/src/pl/plperl/.gitignore index 1a79873..c04f42b 100644 --- a/src/pl/plperl/.gitignore +++ b/src/pl/plperl/.gitignore @@ -4,6 +4,4 @@ /plperl_opmask.h # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/src/pl/plpython/.gitignore b/src/pl/plpython/.gitignore index 70c08db..b0cd31b 100644 --- a/src/pl/plpython/.gitignore +++ b/src/pl/plpython/.gitignore @@ -1,7 +1,5 @@ /spiexceptions.h # Generated subdirectories /expected/python3/ -/log/ /results/ /sql/python3/ -/tmp_check/ diff --git a/src/pl/tcl/.gitignore b/src/pl/tcl/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/src/pl/tcl/.gitignore +++ b/src/pl/tcl/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/src/test/isolation/.gitignore b/src/test/isolation/.gitignore index 42ee945..3b719fe 100644 --- a/src/test/isolation/.gitignore +++ b/src/test/isolation/.gitignore @@ -8,5 +8,3 @@ # Generated subdirectories /results/ -/log/ -/tmp_check/ diff --git a/src/test/modules/commit_ts/.gitignore b/src/test/modules/commit_ts/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/src/test/modules/commit_ts/.gitignore +++ b/src/test/modules/commit_ts/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/src/test/modules/dummy_seclabel/.gitignore b/src/test/modules/dummy_seclabel/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/src/test/modules/dummy_seclabel/.gitignore +++ b/src/test/modules/dummy_seclabel/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/src/test/modules/test_parser/.gitignore b/src/test/modules/test_parser/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/src/test/modules/test_parser/.gitignore +++ b/src/test/modules/test_parser/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/src/test/modules/test_rls_hooks/.gitignore b/src/test/modules/test_rls_hooks/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/src/test/modules/test_rls_hooks/.gitignore +++ b/src/test/modules/test_rls_hooks/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/src/test/modules/test_shm_mq/.gitignore b/src/test/modules/test_shm_mq/.gitignore index 5dcb3ff..19b6c5b 100644 --- a/src/test/modules/test_shm_mq/.gitignore +++ b/src/test/modules/test_shm_mq/.gitignore @@ -1,4 +1,2 @@ # Generated subdirectories -/log/ /results/ -/tmp_check/ diff --git a/src/test/regress/.gitignore b/src/test/regress/.gitignore index 173f995..0fb329d 100644 --- a/src/test/regress/.gitignore +++ b/src/test/regress/.gitignore @@ -2,9 +2,7 @@ /pg_regress # Generated subdirectories -/tmp_check/ /results/ -/log/ # Note: regreesion.* are only left behind on a failure; that's why they're not ignored #/regression.diffs diff --git a/src/test/ssl/.gitignore b/src/test/ssl/.gitignore index a325c2f..9a3e9c17 100644 --- a/src/test/ssl/.gitignore +++ b/src/test/ssl/.gitignore @@ -1,3 +1,2 @@ # Generated by regression tests /client-log -/tmp_check/
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
