Robert Haas wrote: > 2009/12/30 Teodor Sigaev <teo...@sigaev.ru>: > > Sync with current CVS > > I have reviewed this patch and it looks good to me. The only > substantive question I have is why gist_point_consistent() uses a > different coding pattern for the box case than it does for the polygon > and circle cases? It's not obvious to me on the face of it why these > aren't consistent.
Emre Hasegeli just pointed out to me that this patch introduced box_contain_pt() and in doing so used straight C comparison (<= etc) instead of FPlt() and friends. I would think that that's a bug and needs to be changed -- but certainly not backpatched, because gist indexes would/might become corrupt. This is in the context of his inclusion opclass for BRIN http://www.postgresql.org/message-id/CAE2gYzwBZQ=z02zioefnhrxof+1vegqc_cwpvj8lwnqgx1-...@mail.gmail.com -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
