On Thu, May 28, 2015 at 6:07 AM, Gaetano Mendola <mend...@gmail.com> wrote: > I'm playing with a static analyzer and it's giving out some real error > analyzing postgresql code base like the following one > > src/backend/access/transam/commit_ts.c > return *ts != 0 // line 321 > but a few line up (line 315) ts is checked for null, so either is not needed > to check for null or *ts can lead to a null pointer dereference. Same > happens a few line later lines 333 and 339
Thanks for providing detailed information. The function "TransactionIdGetCommitTsData" is currently used only at one place. The caller always passes an valid pointer to this function. So there shouldn't be a problem. But in future if the same function is used at somewhere by passing the NULL pointer then it leads to a crash. By correcting the following way will solve the problem. return ts ? (*ts != 0) : false; instead of retun *ts != 0; Attached a patch for it. Regards, Hari Babu Fujitsu Australia
commit_ts_fix.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
