On Sat, Jun 13, 2015 at 07:52:22AM -0300, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > I have committed the first draft of the 9.5 release notes.  You can view
> > the output here:
> > 
> >     http://momjian.us/pgsql_docs/release-9-5.html
> >     
> > and it will eventually appear here:
> > 
> >     http://www.postgresql.org/docs/devel/static/release.html
> > 
> > I am ready to make suggested adjustments, though I am traveling for
> > conferences for the next ten days so there might a delay in my replies.
> 
> Many people have commented on the "RETURN WHERE" text.  The item in
> question is this:
>       Have CREATE TABLE AS and REFRESH return an OID
> 
> This code was later changed to return ObjectAddress rather than OID;
> this is used to feed event triggers.  To answer the "where" question:
> the OID is returned to ProcessUtilitySlow, where it can be used by the
> DDL-command-collection infrastructure.
> 
> I don't think this particular change needs a mention in the release
> notes, since the ddl command collection is mentioned separately.  I
> would just remove it.

OK, removed.

> In the pg_upgrade section, I think this is a bit strangely worded:
>       Remove pg_upgrade support for 8.3 old clusters (Bruce Momjian)
> How about this?
>       Remove support for upgrading from 8.3 clusters (Bruce Momjian)
> 
> Why do we need a separate mention that pg_upgrade_support was moved to
> backend in the "Additional Modules" section?  Seems to me that having
> it mentioned in the pg_upgrade section would be better.

OK, moved.

> This entry is missing a word at the end:
>       Allow CURRENT/SESSION_USER to specify the current user in
>       certain

OK, wording updated, applied patch attached.

Thanks for the review.
-- 
  Bruce Momjian  <br...@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +
diff --git a/doc/src/sgml/release-9.5.sgml b/doc/src/sgml/release-9.5.sgml
new file mode 100644
index ec49a63..478fd86
*** a/doc/src/sgml/release-9.5.sgml
--- b/doc/src/sgml/release-9.5.sgml
***************
*** 802,808 ****
        <listitem>
         <para>
          Allow <literal>CURRENT</><literal>/SESSION_USER</> to specify the
!         current user in certain (Kyotaro Horiguchi, &Aacute;lvaro Herrera)
         </para>
  
         <para>
--- 802,809 ----
        <listitem>
         <para>
          Allow <literal>CURRENT</><literal>/SESSION_USER</> to specify the
!         current user in some commands (Kyotaro Horiguchi, &Aacute;lvaro
!         Herrera)
         </para>
  
         <para>
***************
*** 870,888 ****
         </para>
        </listitem>
  
-       <listitem>
-        <para>
-         Have <link linkend="SQL-CREATETABLEAS"><command>CREATE
-         TABLE AS</></> and <link
-         linkend="SQL-REFRESHMATERIALIZEDVIEW"><command>REFRESH</></>
-         return an <type>OID</> (&Aacute;lvaro Herrera)
-        </para>
- 
-        <para>
-         WHERE IS THE OID RETURNED?
-        </para>
-       </listitem>
- 
       </itemizedlist>
  
       <sect4>
--- 871,876 ----
***************
*** 1728,1738 ****
  
        <listitem>
         <para>
!         Remove <application>pg_upgrade</> support for 8.3 old clusters
!         (Bruce Momjian)
         </para>
        </listitem>
  
       </itemizedlist>
  
      </sect4>
--- 1716,1732 ----
  
        <listitem>
         <para>
!         Remove support for upgrading from 8.3 clusters (Bruce Momjian)
         </para>
        </listitem>
  
+      <listitem>
+       <para>
+        Move <application>pg_upgrade_support</> code into backend and
+        remove the module (Peter Eisentraut)
+       </para>
+      </listitem>
+ 
       </itemizedlist>
  
      </sect4>
***************
*** 2021,2033 ****
        </para>
       </listitem>
  
-      <listitem>
-       <para>
-        Move <application>pg_upgrade_support</> code into backend and
-        remove the module (Peter Eisentraut)
-       </para>
-      </listitem>
- 
       <listitem>
        <para>
         Move <application>dummy_seclabel</>, <application>test_shm_mq</>,
--- 2015,2020 ----
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to