On Sat, Jun 27, 2015 at 1:32 AM, Robert Haas <robertmh...@gmail.com> wrote:
>
> On Wed, Jun 10, 2015 at 3:34 AM, Amit Kapila <amit.kapil...@gmail.com>
wrote:
> > Okay, I have updated the patch to destroy_tablespace_directories() code
> > as well in the attached patch. I have tried to modify
> > remove_tablespace_symlink(), so that it can be called from
> > destroy_tablespace_directories(), but that is making it more complex,
> > especially due to the reason that destroy_tablespace_directories()
> > treats ENOENT as warning rather than ignoring it.
>
> This pretty obviously doesn't follow style guidelines. You've got it
> started with a capital letter, and there are two spaces between "a"
> and "directory".
>
> errmsg("Not a directory or symbolic link: \"%s\"",
>
Sorry, I think this is left over due to multiple versions exchange
between me and Andrew.
> But it looks OK otherwise, so committed.
>
Thanks.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
