>>>>> "Jeevan" == Jeevan Chalke <jeevan.cha...@enterprisedb.com> writes:

 Jeevan> Hi,

 Jeevan> When we have text column in the GROUPING SETS (and with some specific
 Jeevan> order of columns), we are getting error saying
 Jeevan> "could not determine which collation to use for string comparison"

Good catch.

 Jeevan> After spending enough time, If I understood the code correctly,
 Jeevan> we are re-ordering the sort columns but we are not remapping
 Jeevan> the grpColIdx correctly.

Yup.

 Jeevan> Attached patch which attempts to fix this issue. However I am
 Jeevan> not sure whether it is correct. But it does not add any new
 Jeevan> issues as such.  Added few test in the patch as well.

I wouldn't have bothered moving the Assert; it can be removed. Otherwise
it looks correct.

-- 
Andrew (irc:RhodiumToad)


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to