On Wed, Jul 22, 2015 at 10:04 AM, Peter Eisentraut <pete...@gmx.net> wrote: > On 7/21/15 10:00 AM, Tom Lane wrote: >> I agree; this change may have seemed like a good idea at the time, but >> it was not. Failures during "make check"'s install step are rare enough >> that you don't really need all that output in your face to help with the >> rare situation where it fails. And for the buildfarm's purposes, it is >> surely desirable to segregate that output from the actual check step. > > It wasn't really an idea; it was just not necessary anymore. We can put > it [directing the make install output into a file] back if that's what > people prefer.
OK... Attached are two patches (please merge them into a single commit, I am just separating them as they are separate issues): - 0001 adds a missing entry in test_ddl_deparse's .gitignore. I mentioned that upthread. - 0002 redirects the installation logs into abs_top_builddir/tmp_install/log/install.log. We could redirect it only to abs_top_builddir/log/ but tmp_install is not removed after a run of a regression make target. -- Michael
From 0614062b1d41bd72ed4a0ba000d639607156066d Mon Sep 17 00:00:00 2001 From: Michael Paquier <michael@otacoo.com> Date: Wed, 22 Jul 2015 10:15:20 +0900 Subject: [PATCH 1/2] Add missing entry log/ in .gitignore for test_ddl_deparse Entry forgotten by 9faa6ae1. --- src/test/modules/test_ddl_deparse/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/modules/test_ddl_deparse/.gitignore b/src/test/modules/test_ddl_deparse/.gitignore index 6628455..3337b3d 100644 --- a/src/test/modules/test_ddl_deparse/.gitignore +++ b/src/test/modules/test_ddl_deparse/.gitignore @@ -1 +1,2 @@ +/log/ /results/ -- 2.4.6
From 9df069d70f8c9aeffffcf7254ebfdec85460faf5 Mon Sep 17 00:00:00 2001 From: Michael Paquier <michael@otacoo.com> Date: Wed, 22 Jul 2015 10:24:17 +0900 Subject: [PATCH 2/2] Redirect installation output of make check into a log file dbf2ec1a changed make check such as the installation logs get directed to stdout and stderr, however some recent objections are proving that this was a bad move. Hence put it back into a log file saved as tmp_install/log which is created once per invocation of any make target doing regression tests. --- src/Makefile.global.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Makefile.global.in b/src/Makefile.global.in index 8d1250d..e2f7211 100644 --- a/src/Makefile.global.in +++ b/src/Makefile.global.in @@ -307,9 +307,10 @@ temp-install: ifndef NO_TEMP_INSTALL ifeq ($(MAKELEVEL),0) rm -rf '$(abs_top_builddir)'/tmp_install - $(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install + $(MKDIR_P) '$(abs_top_builddir)'/tmp_install/log + $(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1 endif - $(if $(EXTRA_INSTALL),for extra in $(EXTRA_INSTALL); do $(MAKE) -C '$(top_builddir)'/$$extra DESTDIR='$(abs_top_builddir)'/tmp_install install || exit; done) + $(if $(EXTRA_INSTALL),for extra in $(EXTRA_INSTALL); do $(MAKE) -C '$(top_builddir)'/$$extra DESTDIR='$(abs_top_builddir)'/tmp_install install >>'$(abs_top_builddir)'/tmp_install/log/install.log || exit; done) endif PROVE = @PROVE@ -- 2.4.6
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
