On 07/24/2015 01:27 PM, Heikki Linnakangas wrote:
On 06/25/2015 07:40 AM, Michael Paquier wrote:
On Tue, May 26, 2015 at 3:39 PM, Michael Paquier wrote:
Here is v6, a rebased version on HEAD (79f2b5d). There were some
conflicts with the indentation and some other patches related to
pg_rewind and initdb's tests.
Attached is v7, rebased on 0b157a0.
Thanks! I fiddled with this a bit more, to centralize more of the
platform-dependent stuff to RewindTest.pm. Also, Windows doesn't have
"cat" and "touch" if you haven't installed MinGW, so I replaced those
calls with built-in perl code.
Can you double-check that the attached still works in your
environment? It works for me now.
Note: I had some trouble installing IPC::Run on my system, with
ActiveState Perl and MSVC. There is no PPM package of that for
Windows, so I had to do "cpan install IPC::Run". That downloaded the
MinGW C compiler and make utility, which took a while. But some of the
IPC::Run regression tests failed, and the installation was aborted. I
forced my way through that "notest install IPC::Run". The next
obstacle was that "vcregress <anything>" no longer worked. It
complained about finding some function in the Install module. Turns
out that when it installed the C compiler and make utility, it also
installed a module called "install" from cpan, which has the same name
as the PostgreSQL Install.pm module. We really should rename our
module. I got through that by manually removing the system install.pm
module from the perl installation's site directory. But after that, it
worked great :-).
We need to put some instructions in the docs on how to install
IPC::Run on Windows. I can write up something unless you're eager to.
AFAIK all you need to do is put Run.pm in the right place. It doesn't
need any building, IIRC, and the current version can be got from
<http://cpansearch.perl.org/src/TODDR/IPC-Run-0.94/lib/IPC/Run.pm>
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
