Ildus Kurbangaliev wrote: > A new version of the patch. I used your idea with macros, and with tranches > that > allowed us to remove array with names (they can be written directly to the > corresponding > tranche).
Just a bystander here, I haven't reviewed this patch at all, but I have two questions, 1. have you tested this under -DEXEC_BACKEND ? I wonder if those initializations are going to work on Windows. 2. why keep the SLRU control locks as individual locks? Surely we could put them in the SlruCtl struct and get rid of a few individual lwlocks? Also, I wonder if we shouldn't be doing this in two parts, one that changes the underlying lwlock structure and another one to change pg_stat_activity. We have CppAsString() in c.h IIRC, which we use instead of # (we do use ## in a few places though). I wonder if that stuff has any value anymore. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers