On Thu, Sep 10, 2015 at 09:59:41PM -0400, Bruce Momjian wrote: > On Fri, Sep 11, 2015 at 12:41:09AM +0000, Hyongtae Lim wrote: > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature: tested, passed > > Spec compliant: tested, passed > > Documentation: not tested > > > > This looks good to me. > > I've done some tests(pg_dumpall & restore with sql, upgrade test(8.4, 9.x, > > ...)) and there was no problems. > > so I'm marking this as ready for committer. > > Thanks. I am going to commit it in the next 24 hours. Thanks.
Patch applied and marked as committed in the commitfest app. One odd thing I found in exhaustive testing is that pre-9.3, we use a line starting with \connect to identify when the pg_dumpall globals end and the per-database information begins. (In 9.3+, we do per-database dumps to allow parallel dump/restore.) I modified the patch for pre-9.3 to prefix a space for \connect lines when we are jumping in and out of the database so we can alter its tablespace. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
