Hi, thank you for pointing it out. At Wed, 16 Sep 2015 14:02:30 +0900, Yugo Nagata <nag...@sraoss.co.jp> wrote in <20150916140230.a232426c.nag...@sraoss.co.jp> > I found that codes about T_PrivGrantee was removed > by the following commit; > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=31eae6028eca4365e7165f5f33fee1ed0486aee0 > > but T_PrivGrantee is left in NodeTag in src/include/nodes/nodes.h. > > Is it intended?
I simply forgot to remove it. The comment for NodeTag says that, ==== * Note that the numbers of the node tags are not contiguous. We left holes * here so that we can add more tags without changing the existing enum's. * (Since node tag numbers never exist outside backend memory, there's no * real harm in renumbering, it just costs a full rebuild ...) ==== However, I think it'd be better to be removed. Thoughts? The attached patch simply removes it. -- Kyotaro Horiguchi NTT Open Source Software Center
>From c18f99b5eafaa7f3d2867762740bd35133afd3aa Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi <horiguchi.kyot...@lab.ntt.co.jp> Date: Wed, 16 Sep 2015 16:06:09 +0900 Subject: [PATCH] Remove unused node type tag T_PrivGrantee. T_PrivGrantee became useless by the commit 31eae6028eca4365e7165f5f33fee1ed0486aee0. This commit renumbers some of node type tags. --- src/include/nodes/nodes.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/nodes/nodes.h b/src/include/nodes/nodes.h index 748e434..274480e 100644 --- a/src/include/nodes/nodes.h +++ b/src/include/nodes/nodes.h @@ -413,7 +413,6 @@ typedef enum NodeTag T_SortGroupClause, T_GroupingSet, T_WindowClause, - T_PrivGrantee, T_FuncWithArgs, T_AccessPriv, T_CreateOpClassItem, -- 1.8.3.1
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
