On Thu, Oct 15, 2015 at 10:44 PM, Robert Haas <robertmh...@gmail.com> wrote:
> On Thu, Oct 15, 2015 at 3:04 AM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: > > I confirmed that an epqtuple of foreign parameterized scan is > > correctly rejected by fdw_recheck_quals with modified outer > > tuple. > > > > I have no objection to this and have two humble comments. > > > > In file_fdw.c, the comment for the last parameter just after the > > added line seems to be better to be aligned with other comments. > > I've pgindented the file. Any other space we might choose would just > be changed by the next pgindent run, so there's no point in trying to > vary. > > > In subselect.c, the added break is in the added curly-braces but > > it would be better to place it after the closing brace, like the > > other cases. > > Changed that, and committed. > With the latest sources having this commit, when I follow same steps, I get ERROR: unrecognized node type: 525 error. It looks like, we have missed to handle T_RestrictInfo. I am getting this error from expression_tree_mutator(). > -- > Robert Haas > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers > -- Jeevan B Chalke Principal Software Engineer, Product Development EnterpriseDB Corporation The Enterprise PostgreSQL Company
