Robins, On 2015/10/29 10:40, Robins wrote: > Hi, > > Was reviewing recent commits, and it seems the following commit adds an > extra line to some comments. Just wanted to cross-check if that was > intentional. > > Commit: http://goo.gl/zxA00l > Pre-Commit: http://goo.gl/2DpLxi > Post-Commit: http://goo.gl/eKcNm3
You can see a minor change in the "extra line" - member vs. members in the first and second version, respectively, of essentially the same message. errmsg_plural() function determines whether to output the singular version or the plural based on numeric value of the first variadic argument passed to it. For example, if "%d" in the formatted output turns out be 1, "... 1 multixact members ..." in the output message sounds awkward. So does "... 10 multixact member". Hence the committed change. Thanks, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
