On 2015-11-03 19:14:44 -0800, Peter Geoghegan wrote: > On Tue, Nov 3, 2015 at 7:10 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > This seems like a fine teaching moment in which to point out our > > longstanding error message style guideline that says not to put > > names of C functions into error messages in the first place. > > I don't ordinarily do that, of course, but I thought it was important > to be consistent with other such elog() calls within heapam.c.
Internal, super unlikely, elog()s don't seem to need much consistency among themselves. > I think that there at least 10 that look like this. Let's rather rip those function names out. Unless somebody protests I'm going to do so in 9.5/master. Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
