On Thu, Nov 19, 2015 at 11:04 AM, Marko Tiikkaja wrote: > This was discussed in 2010 when CTEs got the same treatment, and I agree > with what was decided back then. If someone needs to make PreparableStmt > different from what COPY and CTEs support, we can split them up. But > they're completely identical after this patch, so splitting them up right > now is somewhat pointless. > Further, if someone's going to add new stuff to PreparableStmt, she should > probably think about whether it would make sense to add it to COPY and CTEs > from day one, too, and in that case not splitting them up is actually a win.
Personally, I would take it on the safe side and actually update it. If someone were to add a new node type in PreparableStmt I am pretty sure that we are going to forget to update the COPY part, leading us to unwelcome bugs. And that would not be cool. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
