On Fri, Dec 4, 2015 at 11:47 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Dec 2, 2015 at 12:33 AM, Pavel Stehule <pavel.steh...@gmail.com> > wrote: >>> Yeah, I don't think that's a big issue either to be honest. The code >>> is kept consistent a maximum with what is there previously. >>> >>> Patch is switched to ready for committer. >> >> perfect >> >> Thank you very much to all > > I did some edits on this patch and was all set to commit it when I ran > the regression tests and discovered that this breaks 130 out of the > 160 regression tests. Allow me to suggest that before submitting a > patch, or marking it ready for commiter, you test that 'make check' > passes.
Mea culpa. I thought I did a check-world run... But well... > For the most part, the cleanups in this version are just cosmetic: I > fixed some whitespace damage, and reverted some needless changes to > the psql references page that were whitespace-only adjustments. In a > few places, I tweaked documentation or comment language. I also > hoisted the psqlrc handling out of an if statement where it was the > same in both branches. Other than that, this version is, I believe, > the same as Pavel's last version. Thanks, I looked at that again and problem is fixed as attached. -- Michael
-- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers