Tom Lane wrote: > Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > > I confirmed that adding that line makes the new file get compiled. I > > also noticed these warnings when compiling it: > > > In file included from > > /usr/lib/gcc/x86_64-w64-mingw32/4.9-win32/include/stdarg.h:1:0, > > from /pgsql/source/master/src/include/c.h:85, > > from /pgsql/source/master/src/include/postgres_fe.h:25, > > from /pgsql/source/master/src/port/win32security.c:17: > > /pgsql/source/master/src/port/win32security.c: In function ‘log_error’: > > /pgsql/source/master/src/port/win32security.c:37:11: warning: passing > > argument 1 of ‘__builtin_va_start’ from incompatible pointer type > > va_start(fmt, ap); > > ^ > > I take it this code is quite untested, because what that's whining > about is that the arguments of va_start() are reversed.
It is untested by me, yes. Pushed a fix for this problem. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
