Hello, At Mon, 4 Jan 2016 15:29:34 +0900, Michael Paquier <michael.paqu...@gmail.com> wrote in <CAB7nPqTp5RoHxcp8YxejGMjRjjtLaXCa8=-ber7znbnbpzp...@mail.gmail.com> > > Attached latest v5 patch. > > Please review it. > > Something that I find rather scary with this patch: could it be > possible to get actual regression tests now that there is more > machinery with PostgresNode.pm? As syncrep code paths get more and > more complex, so are debugging and maintenance.
The test on the whole replication system will very likely to be too complex and hard to stabilize, and would be disproportionately large to other tests. This patch mainly changes the logic to choose the next syncrep standbys and calculate the 'synched' LSNs, so performing separate module tests for the logics, then perform the test for the behavior according to the result of that by, perhaps, PostgresNode.pm would remarkably reduce the labor for testing. Could we have some tapping point for individual testing of the logics in appropriate way? In order to do so, the logics should be able to be fed arbitrary complete set of parameters, in other words, defining a kind of API to use the logics from the core side, even though it is not an extension. Then we will *somehow* kick the API with some set of parameters in regest. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers