I wrote: > Attached is a draft patch that does things this way. BTW, the bulk of the changes in this patch are just there to pass down the DumpOptions struct to where it's needed, following some pre-existing work that passed that around as a separate pointer. I wonder why things were done that way, rather than adding a DumpOptions pointer in the Archive struct? The vast majority of the functions I had to touch already had an Archive* parameter, and would not have needed to be touched if it were done the other way. I'm tempted to push a preliminary patch that adds such a field and gets rid of DumpOptions as a separate parameter to anything that also takes an Archive* pointer.
regards, tom lane -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers