Amit Langote <langote_amit...@lab.ntt.co.jp> writes: > Why does the argument include_notnull argument exist if > get_relation_constraints() is being called from only one place? Perhaps we > could remove it and add the IS NOT NULL test expression unconditionally if > there are any NOT NULL columns.
Well, you could argue why have a routine at all instead of inlining it into the one caller. IIRC the thought was that other likely uses of constraint-fetching might want to see only the actual check constraints. Is there some positive benefit from removing the argument? regards, tom lane -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers