On 01/16/2016 06:07 AM, Michael Paquier wrote: > On Sun, Dec 27, 2015 at 5:39 AM, Joe Conway <m...@joeconway.com> wrote: >> First installment -- pg_config function/view as a separate patch, >> rebased to current master. > > Documentation would be good to have.
I'm definitely happy to write the docs, but earlier it was not clear that there was enough support for this patch at all, and I don't want to waste cycles writing docs for a feature that ultimately does not get committed. What's the current feel for whether this feature in general is a good idea or bad? > ! # don't include subdirectory-path-dependent -I and -L switches > ! STD_CPPFLAGS := $(filter-out -I$(top_srcdir)/src/include > -I$(top_builddir)/src/include,$(CPPFLAGS)) > ! STD_LDFLAGS := $(filter-out -L$(top_builddir)/src/port,$(LDFLAGS)) > ! override CPPFLAGS += -DVAL_CONFIGURE="\"$(configure_args)\"" > ! override CPPFLAGS += -DVAL_CC="\"$(CC)\"" > ! override CPPFLAGS += -DVAL_CPPFLAGS="\"$(STD_CPPFLAGS)\"" > ! override CPPFLAGS += -DVAL_CFLAGS="\"$(CFLAGS)\"" > ! override CPPFLAGS += -DVAL_CFLAGS_SL="\"$(CFLAGS_SL)\"" > ! override CPPFLAGS += -DVAL_LDFLAGS="\"$(STD_LDFLAGS)\"" > ! override CPPFLAGS += -DVAL_LDFLAGS_EX="\"$(LDFLAGS_EX)\"" > ! override CPPFLAGS += -DVAL_LDFLAGS_SL="\"$(LDFLAGS_SL)\"" > ! override CPPFLAGS += -DVAL_LIBS="\"$(LIBS)\"" > This duplication from src/bin/pg_config is a bad idea. Couldn't we do > something in src/common instead that sets up values at compilation > time in a routine (perhaps set of routines) available for both the > frontend and backend? Will take a look at it. Joe -- Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development
Description: OpenPGP digital signature