On Fri, Jan 29, 2016 at 11:53 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > I removed the above and added the following for that case. > > + /* Complete ALTER DATABASE|FUNCTION|ROLE|USER ... SET <name> */ > + else if (Matches2("ALTER", "DATABASE|FUNCTION|ROLE|USER") && > + TailMatches2("SET", MatchAny)) > + COMPLETE_WITH_LIST2("FROM CURRENT", "TO"); > > Attached is the updated version of the patch.
"ALTER FUNCTION foo(bar)" suggests OWNER TO, RENAME TO and SET SCHEMA. I think that we had better suggesting SET instead of SET SCHEMA, and add SCHEMA in the list of things suggested by SET. "ALTER DATABASE foodb SET foo_param" should suggest TO/= but that's not the case. After adding TO/= manually, a list of values is suggested though. Same problem with ALTER ROLE and ALTER FUNCTION. > I also added the change that Sawada suggested, to the patch. OK. -- Michael -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers