There seems to be double successive assignment to fdw_private in recent commit. Here's patch to remove the first one.
On Wed, Feb 3, 2016 at 7:40 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Feb 2, 2016 at 10:42 PM, Corey Huinker <corey.huin...@gmail.com> > wrote: > >> I don't see how. There really is no declaration in there for a > >> variable called server. > > > > Absolutely correct. My only guess is that it was from failing to make > clean > > after a checkout/re-checkout. A good reason to have even boring > regression > > tests. > > > > Regression tests added. > > Committed. > > -- > Robert Haas > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index d5c0383..c95ac05 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -1009,22 +1009,20 @@ postgresGetForeignPlan(PlannerInfo *root, * expressions to be sent as parameters. */ initStringInfo(&sql); deparseSelectStmtForRel(&sql, root, baserel, remote_conds, best_path->path.pathkeys, &retrieved_attrs, ¶ms_list); /* * Build the fdw_private list that will be available to the executor. * Items in the list must match enum FdwScanPrivateIndex, above. */ - fdw_private = list_make2(makeString(sql.data), - retrieved_attrs); fdw_private = list_make3(makeString(sql.data), retrieved_attrs, makeInteger(fpinfo->fetch_size)); /* * Create the ForeignScan node from target list, filtering expressions, * remote parameter expressions, and FDW private information. * * Note that the remote parameter expressions are stored in the fdw_exprs * field of the finished plan node; we can't keep them in private state
-- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers