Hi. I’ve looked over proposed patch and migrated my shell tests scripts that i’ve used for testing twophase commits on master/slave to this test framework. Everything looks mature, and I didn’t encountered any problems with writing new tests using this infrastructure.
>From my point of view I don’t see any problems to commit this patches in their >current state. Also some things that came into mind about test suite: 0) There are several routines that does actual checking, like is/command_ok/command_fails. I think it will be very handy to have wrappers psql_ok/psql_fails that calls psql through the command_ok/fails. 1) Better to raise more meaningful error when IPC::Run is absend. 2) --enable-tap-tests deserves mention in test/recovery/README and more obvious error message when one trying to run make check in test/recovery without --enable-tap-tests. 3) Is it hard to give ability to run TAP tests in extensions? 4) It will be handy if make check will write path to log files in case of failed test. 5) psql() accepts database name as a first argument, but everywhere in tests it is ‘postgres’. Isn’t it simpler to store dbname in connstr, and have separate function to change database? 6) Clean logs on prove restart? Clean up tmp installations? 7) Make check sets PGPORT PG_REGRESS for prove. Is it necessary? > On 22 Jan 2016, at 09:17, Michael Paquier <michael.paqu...@gmail.com> wrote: > > On Mon, Dec 21, 2015 at 4:45 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> As this thread is stalling a bit, please find attached a series of >> patch gathering all the pending issues for this thread: >> - 0001, fix config_default.pl for MSVC builds to take into account TAP tests >> - 0002, append a node name in get_new_node (per Noah's request) >> - 0003, the actual recovery test suite >> Hopefully this facilitates future reviews. > > Patch 2 has been pushed as c8642d9 (thanks Alvaro). The remaining two > patches still apply and pass cleanly. > -- > Michael > > > -- > Sent via pgsql-hackers mailing list (firstname.lastname@example.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers Stas Kelvich Postgres Professional: http://www.postgrespro.com The Russian Postgres Company -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers