> -----Original Message----- > From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Robert Haas > Sent: Thursday, February 11, 2016 1:26 PM > To: Kaigai Kouhei(海外 浩平) > Cc: Andres Freund; Amit Kapila; pgsql-hackers > Subject: Re: CustomScan in a larger structure (RE: [HACKERS] CustomScan > support > on readfuncs.c) > > On Wed, Feb 10, 2016 at 1:25 AM, Kouhei Kaigai <kai...@ak.jp.nec.com> wrote: > > It is pretty good! > > > > The attached patch (primary one) implements the above idea. > > > > Now ExtensibleNode works as a basis structure of data container, > > regardless of CustomScan and ForeignScan. > > Also, fdw_private and custom_private are de-defined to Node * type > > from List * type. It affected to a few FDW APIs. > > I extracted the subset of this that just creates the extensible node > framework and did some cleanup - the result is attached. I will > commit this if nobody objects. > I have no objection of course.
> I think the part about whacking around the FDW API is a little more > potentially objectionable to others, so I want to hold off doing that > unless a few more people chime in with +1. Perhaps we could start a > new thread to talk about that specific idea. This is useful even > without that, though. > Thanks, -- NEC Business Creation Division / PG-Strom Project KaiGai Kohei <kai...@ak.jp.nec.com> -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers