Jeff Janes wrote: > If I give pgbench an empty file, I get a segfault. > > $ touch empty.sql > $ src/bin/pgbench/pgbench -T 60 -f empty.sql > starting vacuum...end. > Segmentation fault (core dumped)
I fixed this by checking whether the first command is NULL; originally this case was handled by checking whether the command list itself was NULL. It could also be fixed by having process_file() return NULL in the case of an command-less file, but it seemed more churn for no actual reason, since the case is going to be rejected by exiting the program anyway. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
