Hello, At Wed, 17 Feb 2016 09:13:01 +0000, Simon Riggs <si...@2ndquadrant.com> wrote in <canp8+jlbge_ybxulgzxvce44oob8v0t93e5_inhvbde2pxk...@mail.gmail.com> > On 17 February 2016 at 08:34, Kyotaro HORIGUCHI < > horiguchi.kyot...@lab.ntt.co.jp> wrote: > > > > > > I'm guessing this would require making the pre-translated error text > > > available to plugins as well as translated form. > > > > If I understand you correctly, edata->messgage_id in my patch is > > just what offers the pre-translated error text to plugins. > > > OK, now I understand the patch, I am happy to apply it.
Thank you very much. I have one concern about this patch. I have added an id only for .message in the patch but it theoretically can apply to all other message typs eventually given to gettext() in two macros EVALUATE_MESSAGE(_PLURAL). They are detail, detail_log, hint and context and the modification could be limited within the two macros by doing so but extra four *_id members are to be added to ErrorData. I doubt it is useful for the extra members. If you agree with this, it doesn't seem to me to need more modification. Is there anything else to do? regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
