On Sat, Feb 27, 2016 at 7:37 AM, Michael Paquier wrote: > Date of first message of this thread: Mon, 2 Dec 2013 15:40:41 +0900 > Date of this message: Fri, 26 Feb 2016 16:30:08 -0300 > This has been a long trip. Thanks a lot to all involved. Many people > have reviewed and helped out with this patch.
I just had a closer look at what has been committed, and I found a couple of minor issues, addressed via the patch attached: 1) install-windows.sgml should use the markup command when mentioning bincheck and recoverycheck 2) src/test/recovery/.gitignore is listing /regress_log/ but that's not needed (this is a remnant of a previous version of the patch posted on this thread). 3) Header of 002_archiving.pl mentions that the tests are running on a warm standby, but that's a hot standby (found by Craig and reported on github on my account) 4) src/test/recovery/Makefile is missing a clean target, to remove tmp_check/. 5) src/tools/msvc/clean.bat is missing the same cleanup command for the same thing after running the tests. 6) Header of 004_timeline_switch.pl should perhaps mention that a cascading standby is used (idea of Craig, a good addition IMO) Regards, -- Michael
-- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers