On 2/26/16, Pavel Stehule <pavel.steh...@gmail.com> wrote:
> Sending updated version

I did some changes on top of your last version as that was easier than
commenting about them, see attached.

0001 and 0005 are comment changes.

0002 is really needed, without it the tests fail on Python2.4.

0004 removes more code related to the unused position.

0003 is the most controversial. It removes the ability to pass message
as keyword argument. My reasoning was that keyword arguments are
usually optional and configure extra aspects of the function call
while message is required and fundamental so therefore it should be
positional. If you allow it as keyword as well, you have to deal with
the ambiguity of writing plpy.info('a message', message='a keyword arg
message, does this overwrite the first one or what?').

For the code with my patches on top on I ran the PL/Python tests for
2.4, 2.5, 2.6, 2.7 and 3.5. Everything passed.

Can you have a look at the patches, fold the ones you agree with on
top of yours and send the final version? With that I think this will
be Ready for Committer.

Attachment: 0001-Comment-improvements.patch
Description: binary/octet-stream

Attachment: 0002-Fix-tests-for-Python-2.4.patch
Description: binary/octet-stream

Attachment: 0003-Pass-message-only-as-positional-argument.patch
Description: binary/octet-stream

Attachment: 0004-Get-rid-of-setting-unused-position.patch
Description: binary/octet-stream

Attachment: 0005-Improve-comments.patch
Description: binary/octet-stream

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to