On 2 March 2016 at 13:22, Michael Paquier <michael.paqu...@gmail.com> wrote:
> On Wed, Mar 2, 2016 at 2:18 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> > wrote: > > Tom Lane wrote: > >> I wrote: > >> > Can't use string ("Test::Builder") as a HASH ref while "strict refs" > in use at /usr/share/perl5/Test/Builder.pm line 1798. > >> > >> > The referenced line number is the end of the file, > >> > >> Oh, scratch that; I was looking at the wrong file. Actually, > >> /usr/share/perl5/Test/Builder.pm has > >> > >> sub details { > >> my $self = shift; > >> return @{ $self->{Test_Results} }; > >> } > >> > >> and line 1798 is the "return" statement in that. I still lack enough > >> Perl-fu to decipher this, though. > > > > I think it's complaining about being called as a class method. Perhaps > > this would work: > > > > + foreach my $detail (Test::More->builder->details()) > > Yes, that's the problem. Instead of using details(), summary() is > enough actually. And it is enough to let caller know the failure when > just one test has been found as not passing. See attached. > Thanks. I'm setting up a container with Debian Wheezy, which looks old enough to test proposed framework changes, so I'll be able to test future patches against a real Perl 5.8. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services