On Fri, Mar 11, 2016 at 3:34 PM, Mithun Cy <mithun...@enterprisedb.com>
> On Thu, Mar 10, 2016 at 9:39 PM, Robert Haas <robertmh...@gmail.com>
> >I guess there must not be an occurrence of this pattern in the
> >regression tests, or previous force_parallel_mode testing would have
> >found this problem.  Perhaps this patch should add one?
> I have added the test to select_into.sql. Added Explain select into

I don't see how this test will fail with force_parallel_mode=regress and
max_parallel_degree > 0 even without the patch proposed to fix the issue in
hand.  In short, I don't think this test would have caught the issue, so I
don't see much advantage in adding such a test.  Even if we want to add
such a test case, I think as proposed this will substantially increase the
timing for "Select Into" test which might not be an acceptable test case
addition especially for testing one corner case.

> Explain Analyze produces planning time and execution time even with
> so not adding the same to regress tests.

Yeah, that makes the addition of test for this functionality difficult.
Robert, do you have any idea what kind of test would have caught this issue?

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Reply via email to