Aleksander Alekseev wrote: > Please note that these changes: > > ``` > -#define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62)) > +#define LARGE_OFF_T ((((off_t) 1 << 31) << 31) - 1 + (((off_t) 1 << > 31) << 31)) > ``` > > ... were generated but `autoreconf -iv`. I was not sure what to do > about them. Eventually I decided to keep them. Still these changes could > be safely discarded.
I have noticed these while messing with configure.in too. These are generated by an autoconf as patched by Debian; see http://bugs.debian.org/742780 This is said to fix undefined behavior when off_t is 32 bits. They are not present in stock GNU autoconf 2.69 nor are in autoconf's git repo. I think we should continue to use the output of stock, unpatched autoconf. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
