On 16 March 2016 at 11:00, Robert Haas <robertmh...@gmail.com> wrote:
> I don't see why we would need to leave aggpartial out of the equals()
> check. I must be missing something.
This piece of code:
* Aggrefs for partial aggregates are wrapped up in a PartialAggref,
* we need to look into the PartialAggref to find the Aggref within.
tle = (TargetEntry *) lfirst(lc);
paggref = (PartialAggref *) tle->expr;
if (IsA(paggref, PartialAggref) &&
if equals() compared the aggpartial then this code would fail to find
the Aggref in the subnode due to the aggpartial field being true on
one and false on the other Aggref.
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Sent via pgsql-hackers mailing list (email@example.com)
To make changes to your subscription: