On Wed, Mar 23, 2016 at 1:21 PM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Wed, Mar 23, 2016 at 2:28 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> Attached patch incorporates above comments. >> Please find it. > > Attached is the latest version of the patch based on your patch.
Not really having a look at the core patch yet... + my $result = $node_master->psql('postgres', "SELECT application_name, sync_priority, sync_state FROM pg_stat_replication;"); + print "$result \n"; Having ORDER BY application_name would be good for those queries, and the result outputs could be made more consistent as a result. + # Change the s_s_names = '2[standby1,standby2,standby3]' and check sync state + $node_master->psql('postgres', "ALTER SYSTEM SET synchronous_standby_names = '2[standby1,standby2,standby3]';"); + $node_master->psql('postgres', "SELECT pg_reload_conf();"); Let's add a reload routine in PostgresNode.pm, this patch is not the only one who would use it. --- b/src/test/recovery/t/006_multisync_rep.pl *************** *** 0 **** --- 1,106 ---- + use strict; + use warnings; You may want to add a small description for this test as header. $postgres->AddFiles('src/backend/replication', 'repl_scanner.l', 'repl_gram.y'); + $postgres->AddFiles('src/backend/replication', 'syncrep_scanner.l', + 'syncrep_gram.y'); There is no need for a new routine call here, you can just append the new files on the existing call. -- Michael -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers