Michael Paquier <michael.paqu...@gmail.com> writes: > On Tue, Mar 29, 2016 at 9:52 AM, Robert Haas <rh...@postgresql.org> wrote: >> pgbench: Support double constants and functions.
> Instead of INT64_MIN and INT64_MAX, I think that it would be better to > use PG_INT64_MIN and PG_INT64_MAX. Indeed. > Note as well that DOUBLE is an > existing variable type in VS (while INTEGER is not), Ooops; that one was harder to foresee. > A way to fix compilation here is to rename those tokens to something > that will never conflict, like in the attached to DOUBLE_VAR and > INTEGER_VAR, both exprparse.y and exprparse.l need an update. Agreed, but these symbols represent constants not variables, so I used DOUBLE_CONST and INTEGER_CONST instead. Pushed with those corrections, so that we can get back to looking at my own bugs :-( regards, tom lane -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers