Christoph Moench-Tegeder <c...@burggraben.net> writes: > ## Alvaro Herrera (alvhe...@2ndquadrant.com): >>> The below diff fixes one problem: you can't compare pthread_t values >>> directly. Only the function pthread_equal(3) is defined. Direct >>> comparison usually works because most implementations define pthread_t >>> as an integer type.
>> So is there a platform where this assumption doesn't hold? > E.g. FreeBSD has "typedef struct pthread *pthread_t;" with a > non-trivial "struct pthread". Seems like pointer comparison would be sufficient in that case, so I'm still not following what real-world problem this change fixes. I read the POSIX spec's rationale for pthread_equal and found it utterly unconvincing, BTW. If pthread_equal tries to dereference the given pointer and said pointer is stale, what is the reason to think it even points to still-allocated memory? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers