On April 8, 2016 8:05:31 PM PDT, Tom Lane <t...@sss.pgh.pa.us> wrote: >Alvaro Herrera <alvhe...@2ndquadrant.com> writes: >> Robert Haas wrote: >>> woodlouse and thrips failed like this (and mastodon in a similar but >>> not identical way): >>> >>> "C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) >(1) -> >>> "C:\buildfarm\buildenv\HEAD\pgsql.build\ascii_and_mic.vcxproj" >>> (Standardziel) (2) -> >>> "C:\buildfarm\buildenv\HEAD\pgsql.build\postgres.vcxproj" >(Standardziel) (3) -> >>> (ClCompile Ziel) -> >>> src/backend/access/brin/brin_pageops.c(824): error C2026: string too >>> big, trailing characters truncated >>> [C:\buildfarm\buildenv\HEAD\pgsql.build\postgres.vcxproj] > >> This complaint refers to this line: > >> Assert(BRIN_IS_REGULAR_PAGE(BufferGetPage(oldbuf, NULL, NULL, >> BGP_NO_SNAPSHOT_TEST))); > >> which the compiler complains that gets too long. This is related: >> https://www.postgresql.org/message-id/4407.1435763473%40sss.pgh.pa.us > >Yeah, pademelon thinks it's too long as well. > >> I suggest that we fix this by making BufferGetPage an inline function >> rather than a macro. > >+1
I'll get back to that patch early needy week. Andres -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
