Andres Freund <> writes:
> On 2016-04-13 18:09:18 -0400, Tom Lane wrote:
>> BTW, I just noticed another issue here, which is that FileWriteback
>> and the corresponding smgr routines are declared with bogusly narrow
>> "amount" arguments --- eg, it's silly that FileWriteback only takes
>> an int amount.

> Well, I modeled it after the nearby routines (like FileRead), which all
> only take an amount in int. Now there might be less reason to read a lot
> of data at once, than to flush large amounts; but it still didn't seem
> necessary to break with the rest of the functions in the file.

Well, those APIs are pretty historical.  I think it's useful to get
new ones correct from the outset.

                        regards, tom lane

Sent via pgsql-hackers mailing list (
To make changes to your subscription:

Reply via email to