* Robert Haas (robertmh...@gmail.com) wrote: > On Tue, May 3, 2016 at 10:57 AM, Stephen Frost <sfr...@snowman.net> wrote: > > * Craig Ringer (cr...@2ndquadrant.com) wrote: > >> On 3 May 2016 at 19:04, Rushabh Lathia <rushabh.lat...@gmail.com> wrote: > >> > >> > With commit a9f0e8e5a2e779a888988cb64479a6723f668c84, now pg_dump, use a > >> > bitmap > >> > to represent what to include. With this commit if non-super user is > >> > unable > >> > to perform the dump. > >> > > >> > >> Hm. I think we need a src/bin/pg_dump/t/ test for the TAP suite for this > >> one, because something this fundamental should really have blown the > >> buildfarm up when committed. > > > > I'm in the process of building a pretty comprehensive set, as discussed > > in another thread. > > Are you going to review and commit this patch?
I've already reviewed and commented on why that patch isn't a good idea, please see my other email. I'll be posting the updated set of patches on the other thread shortly which address the performance concerns previously raised about (relatively) empty databases and the TAP test suite that I've been building. Thanks! Stephen
signature.asc
Description: Digital signature
