Since 34d26872ed816b2 ("Support ORDER BY within aggregate function
calls") we use ExecProject() and a slot within advance_aggregates().
Previous to that patch we simply directly filled fcinfo.args with

According to my profiles the new way generally is considerably slower,
but especially so if there are a number of aggregates (which each have a
separate projection).

E.g. the profile of
SELECT SUM(abalance), AVG(abalance), count(*) FROM pgbench_accounts;
starts with
+   18.85%  postgres  postgres           [.] ExecProject
+   10.14%  postgres  postgres           [.] advance_aggregates
+    9.50%  postgres  postgres           [.] advance_transition_function
+    8.92%  postgres  postgres           [.] slot_getsomeattrs

I wonder if we should add a ExecEvalExpr() and/or try to build a single
projection that can compute the input for all transition functions at


Andres Freund

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to