On Sat, May 28, 2016 at 12:28 AM, Andres Freund <and...@anarazel.de> wrote: > > Hi, > > contain_volatile_functions_walker is duplicated, near entirely, in > contain_volatile_functions_not_nextval_walker. >
Previously, I also had same observation. > Wouldn't it have been better not to duplicate, and keep a flag about > ignoring nextval in the context variable? > makes sense. +1 for doing it in the way as you are suggesting. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com