On Tue, Jun 7, 2016 at 12:01 AM, Robert Haas <robertmh...@gmail.com> wrote:
> On Fri, Jun 3, 2016 at 12:31 PM, Stephen Frost <sfr...@snowman.net> wrote:
>>> Stephen, something is smelling wrong in checkExtensionMembership()
>>> since 5d58999, an access method does not have ACLs and I would have
>>> expected that when this routine is invoked in
>>> selectDumpableAccessMethod() the object is not selected as dumpable.
>> Yeah, I saw this also and was going to look into it.
>> I suspect the issue may actually be that dumpAccessMethod() wasn't ever
>> updated to have the appropriate conditionals for each of the components
>> of the object.
>> Specifically, there should be if statements along the lines of:
>> if (aminfo->dobj.dump & DUMP_COMPONENT_DEFINITION)
>>         ArchiveEntry ...
>> if (aminfo->dobj.dump & DUMP_COMPONENT_COMMENT)
>>         dumpComment()
>> towards the end of dumpAccessMethod().
>> I'm not 100% sure that addresses this, but it definitely needs to be
>> fixed also.  I'll take care of it in the next few days.
>> I'll also look more directly into what's going on here this weekend when
>> I've got a bit more time to do so.
> It seems important to get this fixed.  I added it to the open items list.

I added already it as " Access methods created with extensions are
dumped individually ". That's not specific to bloom.

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to