On Fri, Jun 10, 2016 at 12:09 PM, Andres Freund <and...@anarazel.de> wrote: > > On 2016-06-10 11:58:26 +0530, Amit Kapila wrote: > > > > While looking at code in this area, I observed that during replay of > > records (heap_xlog_delete), we first clear the vm, then update the page. > > So we don't have Buffer lock while updating the vm where as in the patch > > (collect_corrupt_items()), we are relying on the fact that for clearing vm > > bit one needs to acquire buffer lock. Can that cause a problem? > > Unsetting a vm bit is always safe, right? >
I think so, which means this should not be a problem area. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
