Andres Freund wrote:
> On 2016-07-15 17:23:57 -0400, Alvaro Herrera wrote:
> > Maybe we should change fix_infomask_from_infobits() to reset
> > HEAP_XMAX_BITS | HEAP_MOVED too (and HEAP_KEYS_UPDATED I suppose), to
> > avoid doing it in each callsite.
> Yea, I was thinking of that as well. But there's code like
> htup->t_infomask &= ~(HEAP_XMAX_BITS | HEAP_MOVED);
> htup->t_infomask2 &= ~HEAP_KEYS_UPDATED;
> if (hot_update)
> so I'd rather only clean this up in master.
Mumble. I don't see any way that this would matter, but I don't object
to doing the cleanup in master only.
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Sent via pgsql-hackers mailing list (firstname.lastname@example.org)
To make changes to your subscription: